boards: st: stm32h573i_dk: Add board variant for app in external flash #97678
+577
−440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Samples
zephyrbot
requested review from
57300,
FRASTM,
GeorgeCGV,
JarmouniA,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
kartben,
maass-hamburg,
marwaiehm-st,
mathieuchopstm,
nashif,
nordicjm and
tejlmand
tpambor
force-pushed
the
stm32h573-flash-layout
branch
from
41f5657 to
152ff6c
Compare
You are right, I missed that, currently it places mcuboot in external flash, so a overlay is necessary for mcuboot. |
etienne-lms
reviewed
Oct 16, 2025
There was a problem hiding this comment.
The overall looks good to me and is more consistent regarding the board initial layout.
For commit "boards: st: stm32h573i_dk: Add board variant for app in external flash":
Would it be worth to add an entry in the board doc to mention the new variant?
For commit "mgmt: hawkbit: Replace overlay with new board variant":
Could you prefix the commit message header line with samples: ?
boards/st/stm32h573i_dk/stm32h573i_dk_stm32h573xx_ext_flash_app.dts
Outdated
Show resolved
Hide resolved
boards/st/stm32h573i_dk/stm32h573i_dk_stm32h573xx_ext_flash_app.dts
Outdated
Show resolved
Hide resolved
tpambor
force-pushed
the
stm32h573-flash-layout
branch
from
152ff6c to
96a7604
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
JarmouniA
reviewed
Oct 22, 2025
tpambor
force-pushed
the
stm32h573-flash-layout
branch
from
91c3987 to
a6736b2
Compare
JarmouniA
previously approved these changes
Oct 22, 2025
tpambor
force-pushed
the
stm32h573-flash-layout
branch
from
a6736b2 to
63c9afe
Compare
tpambor
force-pushed
the
stm32h573-flash-layout
branch
from
63c9afe to
51fb7c3
Compare
JarmouniA
previously approved these changes
Oct 22, 2025
maass-hamburg
previously approved these changes
Oct 22, 2025
…flash Use the zephyr,flash-controller node and the respective compatible 'st,stm32-xspi-nor' to detect if the device is running from external flash, instead of assuming that the parent node of the flash is the SPI controller. This fixes an issue when soc-nv-flash is used as the zephyr,flash node. Signed-off-by: Tim Pambor <[email protected]>
Restore old internal flash layout as default and make app in external flash a new board variant Switch mcuboot to use swap mode and remove the no longer required scratch partitions from the internal and external flash layout. Introduce a 'soc-nv-flash' node in the stm32h573i_dk board DTS file to define the external flash memory parameters used for MCUBoot integration. This way BOOT_MAX_IMG_SECTORS_AUTO can be used to automatically calculate the maximum number of image sectors based on the actual external flash configuration. Signed-off-by: Tim Pambor <[email protected]>
Replace overlay for stm32h573i_dk with new board variant designed to run from external flash. Signed-off-by: Tim Pambor <[email protected]>
Replace overlay for stm32h573i_dk with new board variant designed to run in external flash. Keep stm32h573i_dk as it also can run mcuboot. Signed-off-by: Tim Pambor <[email protected]>
Add stm32h573i_dk and the ext_flash_app board to the allowed boards for the mcuboot tests. Signed-off-by: Tim Pambor <[email protected]>
|
@tpambor rebase needed |
tpambor
force-pushed
the
stm32h573-flash-layout
branch
from
51fb7c3 to
fe64c9b
Compare
|
Rebased and conflicts fixed |
maass-hamburg
approved these changes
Oct 23, 2025
JarmouniA
approved these changes
Oct 23, 2025
|
erwango
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 5d0306c of #88579 moved the
slot0_partition,slot1_partition,scratch_partitionfrom the internal flash to the external OSPI NOR flash. At the same time, thenorpartition on the external NOR flash was deleted. This breaks all applications that rely on theslot0_partition,slot1_partition,scratch_partitionto be on internal flash as well as all applications that use thenorpartition on external flash with thestm32h573i_dkboard.To avoid breaking existing projects and maintain compatibility with previous versions of Zephyr, this PR restores the default flash layout (without scratch partition) and introduces a new board variant
ext_flash_appfor applications stored in external flash. This approach allows users to opt-in to the new flash layout without affecting existing projects.A similar to what is proposed for the STM32H750B-DK in #97037.
Fixes #97423.